Add missing ldap_unbind mapping for php 8.1#8126
Conversation
|
Callmap.php should be updated too |
|
All of the ldap functions in callmap.php seem to use the old |
|
Please take a look at https://psalm.dev/docs/contributing/editing_callmaps/ for the full explanation. Short version: callmap.php contains current signature and versionned files alters it for each successive older version to match with the user's version |
|
Updated ldap_unbind in callmap. It looks like there are other incorrect types for ldap functions. I can try to open another PR for that later, but it's a lot of manual checking. |
|
Thanks! Follow up is welcome :) Some contributor recently made a tool to detect inconsistencies in callmaps (through reflection) and flagged ldap_ functions as potentially wrong: https://github.com/vimeo/psalm/pull/8104/files#diff-b16377a21d55a13a48cbdbdfbdf7479b2d9dda80f93b3b81202f88bd1e230b13R97 You could try to remove this line in a new PR an look at CI results for failures in order to identify cases that would need fixing /cc @SamMousa |
|
See #8121 |
https://www.php.net/manual/en/function.ldap-unbind.php
Seems this function was missed.