Ensure trait_exists() always returns bool#7554
Merged
Conversation
|
I found these snippets: https://psalm.dev/r/c41a43805d<?php
function traitDoesIndeedExist(string $traitName): bool
{
return trait_exists($traitName);
} |
Fixes vimeo#7478 As discussed in the upstream issue, `trait_exists()` always returns `bool`: while it can return `null` when the arguments passed to it do not match (either no arguments, or 3 or more arguments), we do not support that scenario, as that already doesn't respect the type signature of this function. We cut to the point: always make it `bool`, which is the scenario that works under healthy operational conditions. Ref: Roave/BetterReflection#983 (comment) Ref: https://psalm.dev/r/c41a43805d Ref: vimeo#7478 (comment) Ref: vimeo#7478 (comment) Ref: https://3v4l.org/XpHmh
ea8cb6c to
fabcda1
Compare
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7478
As discussed in the upstream issue,
trait_exists()always returnsbool: whileit can return
nullwhen the arguments passed to it do not match (either no arguments, or3 or more arguments), we do not support that scenario, as that already doesn't respect the
type signature of this function.
We cut to the point: always make it
bool, which is the scenario that works under healthyoperational conditions.
Ref: Roave/BetterReflection#983 (comment)
Ref: https://psalm.dev/r/c41a43805d
Ref: #7478 (comment)
Ref: #7478 (comment)
Ref: https://3v4l.org/XpHmh