don't taint the result of most binary operations #6809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found these snippets: https://psalm.dev/r/4e6d6d9566<?php // --taint-analysis
$input = $_GET['foo'];
$var = $input++;
var_dump($var); |
Collaborator
What about |
Collaborator
Author
|
Nice catch, I'll fix that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, only Concat and Coalesce binary ops can pass taint to the result.
To whoever it may concern: this method is called for other Expr, there are other Expr that does not imply tainted results (I'm thinking PostInc for example: https://psalm.dev/r/4e6d6d9566). If someone want to give a hand and list all Expr that could and couldn't pass taint, it would be most helpful and I'd gladly amend this to add them all.
This will fix #6804