Use separate exit code to indicate Psalm finding issues#5087
Merged
muglug merged 3 commits intovimeo:masterfrom Jan 24, 2021
Merged
Use separate exit code to indicate Psalm finding issues#5087muglug merged 3 commits intovimeo:masterfrom
muglug merged 3 commits intovimeo:masterfrom
Conversation
This will allow to distinguish successful run that found some issues from crashes.
Contributor
|
Looks good. What do you think about documenting the different exit codes e.g. at https://github.com/vimeo/psalm/blob/master/docs/running_psalm/command_line_usage.md? |
Collaborator
Author
|
@ohader good point, done. |
Collaborator
|
Thanks! |
danog
pushed a commit
to danog/psalm
that referenced
this pull request
Jan 29, 2021
* Use separate exit code to indicate Psalm finding issues This will allow to distinguish successful run that found some issues from crashes. * Fix e2e test expectations * Documented exit statuses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow to distinguish successful run that found some issues from crash (that results in exit code=1).