Skip to content

Use relative path for example#33565

Merged
kodiakhq[bot] merged 3 commits intovercel:canaryfrom
karlhorky:patch-1
Jan 26, 2022
Merged

Use relative path for example#33565
kodiakhq[bot] merged 3 commits intovercel:canaryfrom
karlhorky:patch-1

Conversation

@karlhorky
Copy link
Copy Markdown
Contributor

The paths starting with slashes in the ESLint config examples are absolute, which are almost never the correct configuration for a project. Using a relative path is a much more common configuration, and leads to much less debugging why these examples don't work.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@kodiakhq kodiakhq Bot merged commit 5c6c385 into vercel:canary Jan 26, 2022
@karlhorky
Copy link
Copy Markdown
Contributor Author

Thanks for the merge @timneutkens !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants