docs: Fix simple typo, preffered -> preferred#1428
Merged
profnandaa merged 1 commit intovalidatorjs:masterfrom Sep 6, 2020
timgates42:bugfix_typo_preferred
Merged
docs: Fix simple typo, preffered -> preferred#1428profnandaa merged 1 commit intovalidatorjs:masterfrom timgates42:bugfix_typo_preferred
profnandaa merged 1 commit intovalidatorjs:masterfrom
timgates42:bugfix_typo_preferred
Conversation
There is a small typo in es/lib/normalizeEmail.js, lib/normalizeEmail.js, src/lib/normalizeEmail.js, validator.js. Should read `preferred` rather than `preffered`.
Codecov Report
@@ Coverage Diff @@
## master #1428 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 95 95
Lines 1254 1254
=========================================
Hits 1254 1254
Continue to review full report at Codecov.
|
Member
|
Nice catch 😅 |
profnandaa
approved these changes
Sep 6, 2020
Member
|
Thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a small typo in es/lib/normalizeEmail.js, lib/normalizeEmail.js, src/lib/normalizeEmail.js, validator.js.
Should read
preferredrather thanpreffered.