Test against valid and invalid US TIN prefixes#1408
Merged
profnandaa merged 1 commit intovalidatorjs:masterfrom Aug 19, 2020
Merged
Test against valid and invalid US TIN prefixes#1408profnandaa merged 1 commit intovalidatorjs:masterfrom
profnandaa merged 1 commit intovalidatorjs:masterfrom
Conversation
The existing isTaxId validation tests only checked the format, while the validation code also tests for valid (US campus) prefixes. The added tests, check that the prefix validations actually work.
Codecov Report
@@ Coverage Diff @@
## master #1408 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 95 95
Lines 1248 1248
=========================================
Hits 1248 1248 Continue to review full report at Codecov.
|
profnandaa
approved these changes
Aug 19, 2020
Member
|
Thanks for your contrib! 🎉 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing isTaxId validation tests only checked the format,
while the validation code also tests for valid (US campus)
prefixes. The added tests, check that the prefix validations
actually work.
This has been done as a safety measure for the code's refactoring and the support of another locale. I will issue these in further PRs.
Checklist