feat(isMobilePhone): add support for Philippine mobile no#1388
feat(isMobilePhone): add support for Philippine mobile no#1388profnandaa merged 7 commits intovalidatorjs:masterfrom
Conversation
Add support for Philippine mobile no.
tux-tn
left a comment
There was a problem hiding this comment.
Please check Contributing guidelines and add the missing parts:
- Adding your code to
src/liband notlib - Writing test cases for your new validation
- Adding an entry in README file for your new locale
|
Hi @tux-tn done with the changes but it won't allow me to re-request review |
tux-tn
left a comment
There was a problem hiding this comment.
@stinkymonkeyph thank you for making the necessary changes, you don't need to create a new pull request. I see that your regex is validating numbers starting with +63 followed by 10 decimals, isn't that the international format of philippine mobile numbers? Can you add the format for domestic callers as well?
Yeah sure, I'll add them as well. |
|
Hi sorry for the late update, been busy with several things. I'm using this package in one of our projects and it was missing ph support. Thank guys for all the good work. |
Great, looking forward to seeing it on next build :) |
profnandaa
left a comment
There was a problem hiding this comment.
LGTM too, thanks for your contrib! 🎉
Add support for Philippine mobile no.