Skip to content

Use webdriver io#399

Merged
ctavan merged 1 commit intomasterfrom
use-webdriver-io
Mar 5, 2020
Merged

Use webdriver io#399
ctavan merged 1 commit intomasterfrom
use-webdriver-io

Conversation

@ctavan
Copy link
Copy Markdown
Member

@ctavan ctavan commented Mar 5, 2020

Our current browser tests were incredibly flaky.

Webdriver.io seems to contain retry logic and other safeguards that we are currently lacking in our custom browserstack-local / selenium-webdriver setup.

Under the hood things should still work similarly, let's see if they are now more stable.

@ctavan ctavan force-pushed the use-webdriver-io branch 2 times, most recently from 4360c0f to 3aa165c Compare March 5, 2020 00:18
@ctavan
Copy link
Copy Markdown
Member Author

ctavan commented Mar 5, 2020

OK, I just produced 3 immediately successful browser CI runs in a row:

Screenshot 2020-03-05 13 04 54

Either BrowserStack is in an extraordinarily good mood right at the moment or the webdriver.io based tests are indeed less flaky than my custom solution.

@ctavan ctavan marked this pull request as ready for review March 5, 2020 12:06
@ctavan ctavan requested review from LinusU and broofa March 5, 2020 12:06
@ctavan
Copy link
Copy Markdown
Member Author

ctavan commented Mar 5, 2020

Note: Should we decide to merge this one I will have to adjust the branch protection settings with respect to the required CI runs.

@ctavan
Copy link
Copy Markdown
Member Author

ctavan commented Mar 5, 2020

Update: I re-ran the failed commits on master, had to re-run them a couple of times until being lucky and all 5 browser tests passed. I reran the webdriver tests, still consistently passing 🎉 !

Copy link
Copy Markdown
Member

@broofa broofa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally using my personal browserstack account and it worked first time. Well done!

@ctavan
Copy link
Copy Markdown
Member Author

ctavan commented Mar 5, 2020

Tested this locally using my personal browserstack account and it worked first time. Well done!

To be fair though: The old setup als usually passed when running from my machine. My suspicion is that something with the networking connection between GitHub actions and BrowserStack is off…

Anyways the new setup looks much more stable. 9 successful builds from GitHub actions in a row and they are also reasonably fast (~2mins).

Our current browser tests were incredibly flaky.

Webdriver.io seems to contain retry logic and other safeguards that we
are currently lacking in our custom browserstack-local /
selenium-webdriver setup.

Under the hood things should still work similarly, let's see if they are
now more stable.
@ctavan ctavan force-pushed the use-webdriver-io branch from 2ccfa23 to fb27ebc Compare March 5, 2020 15:07
@ctavan ctavan merged commit ba65bd1 into master Mar 5, 2020
@ctavan ctavan deleted the use-webdriver-io branch March 5, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants