Fix:(issue_1277) Remove default text for version/help flags#1633
Merged
Conversation
lorensr
approved these changes
Dec 30, 2022
lorensr
left a comment
There was a problem hiding this comment.
Could potentially be useful if it worked on non-book fields? But not for my use case
Contributor
Author
Yes it could but for now I think this is good. With other flags it becomes more involved/non-intuitive so I'm going to punt for now. |
|
Sounds good! |
meatballhat
approved these changes
Jan 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Remove default text for help/version flags
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #1277
Special notes for your reviewer:
(fill-in or delete this section)
Testing
(fill-in or delete this section)
make test
Release Notes
(REQUIRED)