Sets the correct color for popover header bottom border#34026
Conversation
ffoodd
approved these changes
May 18, 2021
Contributor
|
@mdo still need your review here, mostly a design choice IMHO: should the popover header border match the header background, or the popover border? |
Contributor
mdo
approved these changes
Jun 3, 2021
Member
mdo
left a comment
There was a problem hiding this comment.
I personally like the lighter border, but this is clearer and more expected IMO. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34005.
Pull bot accidentally messed up PR #34006, so I disabled it and created this one. Sorry for my naivety 😄