Skip to content

fix: readFile on dir should fail EISDIR not EBADF #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
3cp merged 1 commit into from
Apr 20, 2020
Merged

fix: readFile on dir should fail EISDIR not EBADF #286

3cp merged 1 commit into from
Apr 20, 2020

Conversation

@3cp
Copy link
Collaborator

@3cp 3cp commented Jan 3, 2020

closes #285

@3cp 3cp requested a review from tschaub January 3, 2020 12:08
@3cp
Copy link
Collaborator Author

3cp commented Apr 16, 2020

@tschaub can we get this merged?

@3cp 3cp merged commit b6f6361 into master Apr 20, 2020
@3cp 3cp deleted the fix-read-file-error-code branch April 20, 2020 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tschaub tschaub tschaub approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

EBADF reading directory with readFileSync()

3 participants

@3cp @tschaub