Merged
Conversation
Contributor
Author
|
@casperdcl this is a trivial fix but would sure be a quality-of-life update for us vscode users ^ |
casperdcl
requested changes
Mar 26, 2022
Member
casperdcl
left a comment
There was a problem hiding this comment.
@gordonwatts @aldanor sorry for the delay
Comment on lines
-17
to
-18
| if 'VSCODE_PID' in os.environ: # pragma: no cover | ||
| raise ImportError("vscode") |
Member
There was a problem hiding this comment.
do you know which vscode version exactly this PR applies to? Is there a safer fix like:
Suggested change
| if 'VSCODE_PID' in os.environ: # pragma: no cover | |
| raise ImportError("vscode") | |
| if os.environ.get('some_vscode_version_variable) <= '1337': # pragma: no cover | |
| raise ImportError("vscode") |
There was a problem hiding this comment.
I am afraid I do not know what version it applies to. Nor do I have any experience in knowing how to get the VS code version from the env!
Member
There was a problem hiding this comment.
Ok will include as-is, thanks!
We'll see if anyone complains/suggests a fix later :)
Merged
This was referenced Jun 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no reason to block autonotebook in vscode anymore since vscode-jupyter supports ipywidgets just fine (for almost a year now?).
Closes #1213