replace nose => pytest#1052
Merged
casperdcl merged 10 commits intotqdm:develfrom Oct 24, 2020
pgajdos:denose
Merged
Conversation
Member
|
replaces/closes #1045 |
Contributor
Author
|
@casperdcl what do you insist to fix from above failures? Everything? For example, I do not understand 'Method could be a function'. 'Missing function docstring' by inner()? It was not there even before. And 2.6 build? Thank you for not leaving me alone ;). |
Contributor
Author
|
I am also not sure with 'TestWithInstancesCheck', perhaps you would find better? And class and functions layout, is it ok? |
Member
|
Thanks @pgajdos ... will review later. |
pytest-timer doesn't seem to be working require pytest-cov for py26
- fixes coverage as per https://stackoverflow.com/a/60579142
Codecov Report
@@ Coverage Diff @@
## master #1052 +/- ##
==========================================
- Coverage 86.53% 86.40% -0.14%
==========================================
Files 22 22
Lines 1456 1456
Branches 247 247
==========================================
- Hits 1260 1258 -2
- Misses 165 167 +2
Partials 31 31 |
casperdcl
approved these changes
Oct 24, 2020
Member
casperdcl
left a comment
There was a problem hiding this comment.
- also fixed a py3 CLI bug when using
--delimalong with--updateor--update_to - For later: use
capsys/capsysbinaryinstead of all the painfulclosing(*IO())
This was referenced Oct 24, 2020
Merged
Merged
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nosewill stop working with newerpythonversions.