Alow backend build system to omit get_requires_for_build_sdist hook#2131
Merged
gaborbernat merged 5 commits intotox-dev:masterfrom Jul 31, 2021
Merged
Alow backend build system to omit get_requires_for_build_sdist hook#2131gaborbernat merged 5 commits intotox-dev:masterfrom
get_requires_for_build_sdist hook#2131gaborbernat merged 5 commits intotox-dev:masterfrom
Conversation
get_requires_for_build_sdist hook
get_requires_for_build_sdist hookget_requires_for_build_sdist hook
jugmac00
reviewed
Jul 31, 2021
Member
jugmac00
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
Could you please add a changelog entry? (docs/changelog)
We use towncrier for changelogs.
gaborbernat
approved these changes
Jul 31, 2021
Member
|
Released via https://pypi.org/project/tox/3.24.1/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2130. Briefly, PEP 517 permits some optional hooks for a backend build system. In particular, if
get_requires_for_build_sdisthook is not implemented by the backend, a default implementation that returns an empty list must be assumed. This fix should allow enscons (a build system based on SCons) to work withtoxwhen isolated build option is enabled.Contribution checklist:
(also see CONTRIBUTING.rst for details)
in message body
<issue number>.<type>.rstfor example (588.bugfix.rst)<type>is must be one ofbugfix,feature,deprecation,breaking,doc,misc<your username>"superuser."CONTRIBUTORS(preserving alphabetical order)