Skip to content

Add instructions for choosing pip version#1771

Merged
gaborbernat merged 2 commits intotox-dev:masterfrom
alexmorley:patch-2
Jan 8, 2021
Merged

Add instructions for choosing pip version#1771
gaborbernat merged 2 commits intotox-dev:masterfrom
alexmorley:patch-2

Conversation

@alexmorley
Copy link
Copy Markdown

Thanks for contributing a pull request!

If you are contributing for the first time or provide a trivial fix don't worry too
much about the checklist - we will help you get started.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with "by :user:<your username>"
    • please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by :user:superuser."
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

Comment thread docs/config.rst Outdated

Set to ``true`` if you want virtualenv to upgrade pip/wheel/setuptools to
the latest version.
the latest version. When this is set you may add e.g. ``VIRTUALENV_PIP=20.3.3``
Copy link
Copy Markdown
Member

@gaborbernat gaborbernat Jan 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should work without this flag too, not?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for everyone apparently e.g. #1768. That's why I put you may add, but maybe that isn't clear?

Regardless if you want any specific version that's not exactly latest you do need the flag.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe its clearer now?

Copy link
Copy Markdown
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat merged commit 49edaed into tox-dev:master Jan 8, 2021
ssbarnea pushed a commit to ssbarnea/tox that referenced this pull request Apr 19, 2021
* Add instructions for choosing pip version

* clarify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants