Skip to content

Fix compiler error on wasm with deault features.#129

Merged
tkaitchuck merged 2 commits intotkaitchuck:masterfrom
ar37-rs:master
Oct 23, 2022
Merged

Fix compiler error on wasm with deault features.#129
tkaitchuck merged 2 commits intotkaitchuck:masterfrom
ar37-rs:master

Conversation

@ar37-rs
Copy link
Copy Markdown
Contributor

@ar37-rs ar37-rs commented Sep 23, 2022

@tkaitchuck tkaitchuck merged commit b526344 into tkaitchuck:master Oct 23, 2022
@vavrusa
Copy link
Copy Markdown

vavrusa commented Nov 2, 2022

Hi! wasm32-unknown-unknown isn't always running inside a browser, and 0.8.1 silently breaks for all other runtimes that do not provide the JS interfaces. Would you consider putting this behind a feature flag (js) just like getrandom does it?

@tkaitchuck
Copy link
Copy Markdown
Owner

@ar37-rs Based on this, and:
#143
#141
#140
And the recomended practices here:
https://docs.rs/getrandom/latest/getrandom/#webassembly-support

I am reverting these changes to the toml file.

tkaitchuck added a commit that referenced this pull request Nov 10, 2022
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
@tkaitchuck tkaitchuck mentioned this pull request Nov 10, 2022
tkaitchuck added a commit that referenced this pull request Nov 10, 2022
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants