Skip to content

fix(prefer-explicit-assert): check property existence#476

Merged
Belco90 merged 5 commits intomainfrom
issue-475_incomplete-expect-statement
Sep 19, 2021
Merged

fix(prefer-explicit-assert): check property existence#476
Belco90 merged 5 commits intomainfrom
issue-475_incomplete-expect-statement

Conversation

@Belco90
Copy link
Copy Markdown
Member

@Belco90 Belco90 commented Sep 19, 2021

Checks

  • I have read the contributing guidelines.
  • If some rule is added/updated/removed, I've regenerated the rules list.
  • If some rule meta info is changed, I've regenerated the plugin shared configs.

Changes

  • Check some properties' existence instead of just assuming they always exist.

Context

Fixes #475

@Belco90 Belco90 self-assigned this Sep 19, 2021
Belco90
Belco90 commented Sep 19, 2021
View reviewed changes
Comment thread package.json
Comment thread lib/rules/prefer-explicit-assert.ts
@Belco90 Belco90 merged commit 1949a93 into main Sep 19, 2021
@Belco90 Belco90 deleted the issue-475_incomplete-expect-statement branch September 19, 2021 21:56
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 19, 2021

🎉 This PR is included in version 4.12.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

@gndelia gndelia Awaiting requested review from gndelia

Assignees

@Belco90 Belco90

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[prefer-explicit-assert] Incomplete expect statement causes TypeError

2 participants

@Belco90 @MichaelDeBoey