Skip to content

Add support for flags in DatastoreEmulatorContainer#5993

Merged
eddumelendez merged 3 commits into
mainfrom
datastore_support_flags
Oct 24, 2022
Merged

Add support for flags in DatastoreEmulatorContainer#5993
eddumelendez merged 3 commits into
mainfrom
datastore_support_flags

Conversation

@eddumelendez

@eddumelendez eddumelendez commented Oct 15, 2022

Copy link
Copy Markdown
Member

Datastore can start with additional flags such as --consistency 1.0
which is recommended for testing.

See https://cloud.google.com/sdk/gcloud/reference/beta/emulators/datastore/start

Datastore can start with additional flags such as `--consistency 1.0`
which is recommended for testing.
@eddumelendez eddumelendez requested a review from a team October 15, 2022 09:05
@eddumelendez eddumelendez added this to the next milestone Oct 24, 2022
@eddumelendez eddumelendez merged commit 77f71b8 into main Oct 24, 2022
@delete-merged-branch delete-merged-branch Bot deleted the datastore_support_flags branch October 24, 2022 15:23
@bennetelli

Copy link
Copy Markdown

Thanks for your PR @eddumelendez and also thanks for reviewing and merging it, @kiview :-)

@bennetelli

Copy link
Copy Markdown

one thing: why do you add comments containing methods wrapping the actual method? I first thought you missed to delete it, but these pattern is present in all of the GCP tests and in a similar way also in other tests. Looks like this is some testcontainers magic :-) Maybe you can explain it in a brief manner? Would love to learn something new :)

@kiview

kiview commented Oct 27, 2022

Copy link
Copy Markdown
Member

Hi @bennetelli 😃
These are our markers for referencing code snippets in our docs, by using https://github.com/rnorth/mkdocs-codeinclude-plugin.

@bennetelli

Copy link
Copy Markdown

@kiview @eddumelendez do you know when these changes will be released? :) looks like they are not part of the latest patch release

@kiview

kiview commented Nov 14, 2022

Copy link
Copy Markdown
Member

@bennetelli They will be part of the next testcontainers-java release, which we plan to do soon. Until then, you can always use the latest snapshot version through Jitpack 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants