Skip to content

Use jackson 2.8.8 in k3s module#4928

Merged
kiview merged 1 commit intomasterfrom
k3s-jackson-downgrade
Jan 17, 2022
Merged

Use jackson 2.8.8 in k3s module#4928
kiview merged 1 commit intomasterfrom
k3s-jackson-downgrade

Conversation

@kiview
Copy link
Member

@kiview kiview commented Jan 17, 2022

To ensure the same Jackson version across TC core and modules, this commit manually aligns them, so we don't run into problems with our shaded dependencies.

See also:

force 'com.fasterxml.jackson.core:jackson-databind:2.8.8'

In the long term, we should align them automatically.

To ensure same jackson version across TC core and modules, this commit manually aligns them.
@kiview kiview requested review from bsideup and rnorth as code owners January 17, 2022 13:04
Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a temporary measure

@kiview kiview added this to the next milestone Jan 17, 2022
@kiview kiview merged commit f7dcfa8 into master Jan 17, 2022
@delete-merged-branch delete-merged-branch bot deleted the k3s-jackson-downgrade branch January 17, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants