[couchbase] Explicitly configure service quotas (and allow customizat…#4802
Merged
kiview merged 1 commit intotestcontainers:masterfrom Jan 4, 2022
Merged
[couchbase] Explicitly configure service quotas (and allow customizat…#4802kiview merged 1 commit intotestcontainers:masterfrom
kiview merged 1 commit intotestcontainers:masterfrom
Conversation
Member
Author
|
note: I also reformatted the services file since the whitespace wasn't aligned with the other files. |
…ion). This changeset explicitly configures the service memory quotas to their documented limits by default. This ensures that if a service is enabled, it does not consume more memory than absolutely needed. This is important because some services (like analytics) try to grab memory available which is good for production but of limited use in a testcontainers setting. A new API is also added which allows to customize the memory quota for each service should the test case require more than the minimum (which for most services is 256MB anyways).
kiview
approved these changes
Jan 3, 2022
Member
kiview
left a comment
There was a problem hiding this comment.
LGTM in general, see the comment about having the minimum quota values hardcoded. Maybe it is better (for forward and backward compatibility?) to treat those as default, rather than minimum values?
modules/couchbase/src/main/java/org/testcontainers/couchbase/CouchbaseService.java
Show resolved
Hide resolved
rnorth
approved these changes
Jan 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ion).
This changeset explicitly configures the service memory quotas to their
documented limits by default. This ensures that if a service is enabled,
it does not consume more memory than absolutely needed. This is important
because some services (like analytics) try to grab memory available which
is good for production but of limited use in a testcontainers setting.
A new API is also added which allows to customize the memory quota for
each service should the test case require more than the minimum (which
for most services is 256MB anyways).