[couchbase] Ignore transient primary index creation error.#4681
Merged
kiview merged 1 commit intotestcontainers:masterfrom Dec 10, 2021
Merged
[couchbase] Ignore transient primary index creation error.#4681kiview merged 1 commit intotestcontainers:masterfrom
kiview merged 1 commit intotestcontainers:masterfrom
Conversation
Member
Author
|
Actually, I might have figured out how to properly check before returning as well, so I'll add it to this change. |
This changeset makes sure that when a primary index is created, a transient error is ignored since the indexing engine will automatically retry the statement later. Transient errors can happen because we just created the bucket and the indexer might not have caught up to that bucket just yet, but it will eventually. In addition, a check has been added afterwards to make sure that the primary index is online (so, ready for the user to query) before returning to the caller, improving the overall stability of queries.
Member
Author
|
Updated! Ready for review @kiview |
Member
Author
kiview
approved these changes
Dec 10, 2021
Member
kiview
left a comment
There was a problem hiding this comment.
LGTM, there is really nothing Testcontainers specific about this and I trust you to know best how to deal with Couchbase 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset makes sure that when a primary index is created, a transient
error is ignored since the indexing engine will automatically retry the
statement later.
Transient errors can happen because we just created the bucket and the
indexer might not have caught up to that bucket just yet, but it will
eventually.
A future improvement might grab some state before returning to the user
to ensure the index is created properly, but this should at least fix
the issue that some users are seeing in CI.