e2e: allow running of single node using the e2e app#6982
Merged
Conversation
tychoish
approved these changes
Sep 23, 2021
creachadair
approved these changes
Sep 23, 2021
creachadair
left a comment
There was a problem hiding this comment.
I like this idea. I have a few suggestions, but no real concerns.
…rmint into callum/add-e2e-test-app
…rmint into callum/add-e2e-test-app
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows for the e2e app to be used outside of the e2e harness. This could be useful for larger, geographically-dispersed, and long-living testnets.
Running the e2e app comes with the following options:
Built-in
make node tendermint init validator TMHOME=$HOME/.tendermint ./build/node ./node/built-in.tomlTo make things simpler the e2e application can also be run in the tendermint binary by running
tendermint start --proxy-app testSocket
Part of my reasoning for this change is to have the e2e app potentially replace the persistent kvstore (and perhaps kvstore).