ci: add goreleaser by tac0turtle · Pull Request #5527 · tendermint/tendermint

tac0turtle · 2020-10-19T11:11:43Z

Description

remove scripts that handle releases
add in go releaser to build and populate the release page

Closes: #XXX

examples: https://github.com/marbar3778/tendermint/releases

Opening this PR for review to receive feedback on the open questions.

codecov · 2020-10-19T11:15:36Z

Codecov Report

Merging #5527 into master will decrease coverage by 2.49%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5527      +/-   ##
==========================================
- Coverage   63.48%   60.98%   -2.50%     
==========================================
  Files         194      263      +69     
  Lines       16167    23751    +7584     
==========================================
+ Hits        10263    14484    +4221     
- Misses       4801     7788    +2987     
- Partials     1103     1479     +376

Impacted Files	Coverage Δ
cmd/tendermint/commands/version.go	`0.00% <0.00%> (ø)`
privval/signer_server.go	`89.47% <0.00%> (-5.27%)`	⬇️
types/tx.go	`82.97% <0.00%> (-4.26%)`	⬇️
privval/signer_endpoint.go	`72.72% <0.00%> (-3.04%)`	⬇️
p2p/pex/pex_reactor.go	`78.86% <0.00%> (-1.49%)`	⬇️
mempool/reactor.go	`86.36% <0.00%> (ø)`
proxy/multi_app_conn.go	`48.64% <0.00%> (ø)`
crypto/crypto.go	`0.00% <0.00%> (ø)`
abci/types/util.go	`0.00% <0.00%> (ø)`
behaviour/peer_behaviour.go	`75.00% <0.00%> (ø)`
... and 69 more

lgtm-com · 2020-10-19T11:39:04Z

This pull request fixes 10 alerts when merging 175c3fc into a5d3e19 - view on LGTM.com

fixed alerts:

7 for Illegal raise
3 for Unused import

lgtm-com · 2020-10-19T12:59:09Z

This pull request fixes 10 alerts when merging c348326 into 6e16df8 - view on LGTM.com

fixed alerts:

7 for Illegal raise
3 for Unused import

tac0turtle · 2020-10-19T14:07:08Z

+        uses: goreleaser/goreleaser-action@v2
+        with:
+          version: latest
+          args: release --rm-dist --release-notes=release_notes.md


Here I am adding a markdown file that can contain any info we would like to relay about the release. Any data placed in here will be put into the body of the release. If we would like to have the same message each time, like we do now, this will not be required.

Can we continue to link to the changelog? (Also, I think the message is maybe not exactly the same every time - technically it links to the specific link in the changelog?)

yes, just need to work out how to create the needed link. getting odd dirty git errors with the approaches I have tried.

I have it appearing like so: https://github.com/marbar3778/tendermint/releases/tag/v1.4.7. Our naming template will be 1.4.7 (WARNING: BETA SOFTWARE)

lgtm-com · 2020-10-19T14:48:01Z

This pull request fixes 10 alerts when merging 9a2934b into 6e16df8 - view on LGTM.com

fixed alerts:

7 for Illegal raise
3 for Unused import

melekes

amazing 💯 love it

lgtm-com · 2020-10-20T13:07:17Z

This pull request fixes 10 alerts when merging f30d488 into 9e6248c - view on LGTM.com

fixed alerts:

7 for Illegal raise
3 for Unused import

erikgrinaker

Very excited for this!

Co-authored-by: Erik Grinaker <erik@interchain.berlin>

…dermint into marko/go_releaser

lgtm-com · 2020-10-20T14:29:48Z

This pull request fixes 10 alerts when merging 7599add into 9e6248c - view on LGTM.com

fixed alerts:

7 for Illegal raise
3 for Unused import

tessr · 2020-10-20T14:34:20Z

+        uses: goreleaser/goreleaser-action@v2
+        with:
+          version: latest
+          args: release --rm-dist --release-notes=release_notes.md


Can we continue to link to the changelog? (Also, I think the message is maybe not exactly the same every time - technically it links to the specific link in the changelog?)

tessr · 2020-10-20T14:40:15Z

@@ -261,8 +261,11 @@ Each PR should have one commit once it lands on `master`; this can be accomplish
   - Bump P2P and block protocol versions in  `version.go`, if necessary


One line up, but do we still need to bump the Tendermint version in version.go? Where (if anywhere) do we need to specify the new version?

The new version is picked up via git describe. No need to specify it anymore, but we still need to bump the other versions.

lgtm-com · 2020-10-20T15:14:24Z

This pull request fixes 10 alerts when merging 8c7af97 into 9e6248c - view on LGTM.com

fixed alerts:

7 for Illegal raise
3 for Unused import

lgtm-com · 2020-10-22T10:22:08Z

This pull request fixes 10 alerts when merging 8264bb8 into d4f9066 - view on LGTM.com

fixed alerts:

7 for Illegal raise
3 for Unused import

lgtm-com · 2020-10-22T11:13:29Z

This pull request fixes 10 alerts when merging f1ca010 into d4f9066 - view on LGTM.com

fixed alerts:

7 for Illegal raise
3 for Unused import

lgtm-com · 2020-10-27T09:29:45Z

This pull request fixes 10 alerts when merging ca6e229 into 38587d8 - view on LGTM.com

fixed alerts:

7 for Illegal raise
3 for Unused import

Co-authored-by: Erik Grinaker <erik@interchain.berlin> Co-authored-by: Alessio Treglia <alessio@tendermint.com>

tac0turtle added 2 commits October 19, 2020 13:10

add goreleaser

6134e3e

remove release ci from circle

175c3fc

tac0turtle commented Oct 19, 2020

View reviewed changes

Comment thread version/version.go Outdated

remove -rc* from version

c348326

tac0turtle commented Oct 19, 2020

View reviewed changes

tac0turtle added 2 commits October 19, 2020 16:09

remove publish and release

b6e5cd4

Merge branch 'master' into marko/go_releaser

9a2934b

tac0turtle marked this pull request as ready for review October 19, 2020 15:52

tac0turtle requested review from ebuchman, erikgrinaker, melekes and tessr as code owners October 19, 2020 15:52

tac0turtle requested a review from alessio October 19, 2020 15:52

melekes approved these changes Oct 20, 2020

View reviewed changes

Comment thread .goreleaser.yml Outdated

tac0turtle added 2 commits October 20, 2020 14:24

modify release process

06a5574

add in release notes section to contributing

f30d488

Merge branch 'master' into marko/go_releaser

6a83560

erikgrinaker reviewed Oct 20, 2020

View reviewed changes

Comment thread .github/workflows/release.yml

Comment thread .goreleaser.yml Outdated

erikgrinaker reviewed Oct 20, 2020

View reviewed changes

Comment thread version/version.go Outdated

Comment thread scripts/release_management/sha-files.py

tac0turtle and others added 3 commits October 20, 2020 15:38

Update .goreleaser.yml

8043032

Co-authored-by: Erik Grinaker <erik@interchain.berlin>

remove extra variable

2f6fbb4

Merge branch 'marko/go_releaser' of https://github.com/tendermint/ten…

7599add

…dermint into marko/go_releaser

tessr reviewed Oct 20, 2020

View reviewed changes

remove version

8c7af97

tac0turtle force-pushed the marko/go_releaser branch from 1c65a02 to 8c7af97 Compare October 20, 2020 14:47

add release notes outside of the repo

8264bb8

tac0turtle requested review from erikgrinaker and tessr October 22, 2020 09:59

tac0turtle added 2 commits October 22, 2020 12:46

remove gitcommit

ac55c76

cleanup extra echos

f1ca010

tac0turtle added 2 commits October 27, 2020 10:01

Merge branch 'master' into marko/go_releaser

fd5ff74

fix linter

ca6e229

tessr approved these changes Oct 27, 2020

View reviewed changes

tac0turtle merged commit d0db59e into master Oct 27, 2020

tac0turtle deleted the marko/go_releaser branch October 27, 2020 12:54

tac0turtle added a commit that referenced this pull request Oct 27, 2020

ci: add goreleaser (#5527)

a9112aa

Co-authored-by: Erik Grinaker <erik@interchain.berlin> Co-authored-by: Alessio Treglia <alessio@tendermint.com>

tac0turtle added a commit that referenced this pull request Oct 28, 2020

ci: add goreleaser (#5527)

8f1a17a

Co-authored-by: Erik Grinaker <erik@interchain.berlin> Co-authored-by: Alessio Treglia <alessio@tendermint.com>

tac0turtle added a commit that referenced this pull request Oct 28, 2020

ci: add goreleaser (#5527)

96dda88

Co-authored-by: Erik Grinaker <erik@interchain.berlin> Co-authored-by: Alessio Treglia <alessio@tendermint.com>

cmwaters mentioned this pull request Feb 22, 2022

docs: remove spec section from v0.34 docs #7940

Merged

This was referenced Apr 22, 2022

feature/GRAPH 306 v0.34.13 dm graphprotocol/tendermint#15

Merged

feature/GRAPH 306 v0.34.14 dm graphprotocol/tendermint#16

Merged

		@@ -261,8 +261,11 @@ Each PR should have one commit once it lands on `master`; this can be accomplish
		- Bump P2P and block protocol versions in `version.go`, if necessary

Conversation

tac0turtle commented Oct 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

codecov Bot commented Oct 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

lgtm-com Bot commented Oct 19, 2020

Uh oh!

lgtm-com Bot commented Oct 19, 2020

Uh oh!

tac0turtle Oct 19, 2020

Choose a reason for hiding this comment

Uh oh!

tessr Oct 20, 2020

Choose a reason for hiding this comment

Uh oh!

tac0turtle Oct 21, 2020

Choose a reason for hiding this comment

Uh oh!

tac0turtle Oct 22, 2020

Choose a reason for hiding this comment

Uh oh!

lgtm-com Bot commented Oct 19, 2020

Uh oh!

melekes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lgtm-com Bot commented Oct 20, 2020

Uh oh!

erikgrinaker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lgtm-com Bot commented Oct 20, 2020

Uh oh!

tessr Oct 20, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tessr Oct 20, 2020

Choose a reason for hiding this comment

Uh oh!

tac0turtle Oct 20, 2020

Choose a reason for hiding this comment

Uh oh!

lgtm-com Bot commented Oct 20, 2020

Uh oh!

lgtm-com Bot commented Oct 22, 2020

Uh oh!

lgtm-com Bot commented Oct 22, 2020

Uh oh!

lgtm-com Bot commented Oct 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tac0turtle commented Oct 19, 2020 •

edited

Loading

codecov Bot commented Oct 19, 2020 •

edited

Loading