rpc/client: take context as first param#5347
Merged
Conversation
1d757a8 to
b47f4a1
Compare
Codecov Report
@@ Coverage Diff @@
## master #5347 +/- ##
==========================================
+ Coverage 60.83% 61.43% +0.59%
==========================================
Files 203 259 +56
Lines 20526 23378 +2852
==========================================
+ Hits 12488 14363 +1875
- Misses 6961 7564 +603
- Partials 1077 1451 +374
|
0f84dc2 to
af3bbae
Compare
af3bbae to
3e53dd6
Compare
erikgrinaker
suggested changes
Sep 17, 2020
erikgrinaker
approved these changes
Sep 22, 2020
c0330fd to
0bb759d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5145