Conversation
tac0turtle
reviewed
Sep 2, 2020
| var evType abci.EvidenceType | ||
| switch ev.(type) { | ||
| case *DuplicateVoteEvidence: | ||
| evType = ABCIEvidenceTypeDuplicateVote |
Contributor
There was a problem hiding this comment.
lines 17-19 in this file should be removed.
Contributor
Author
There was a problem hiding this comment.
lol you couldn't write the message there so you did it here. Ahh the faults in github. Thanks for the heads up though
Codecov Report
@@ Coverage Diff @@
## master #5324 +/- ##
==========================================
+ Coverage 60.83% 62.36% +1.52%
==========================================
Files 203 259 +56
Lines 20526 26213 +5687
==========================================
+ Hits 12488 16348 +3860
- Misses 6961 8471 +1510
- Partials 1077 1394 +317
|
2 tasks
iKapitonau
pushed a commit
to scrtlabs/tendermint
that referenced
this pull request
Oct 16, 2025
…nt#5324) (tendermint#5407) --- Updates the consensus reactor to validate that a received proposal will not contain more parts than the amount of chunks that it would take to build a block whos size is equal to `ConsensusParams.Block.MaxBytes`. Original PR is here cometbft/cometbft#5309, but reopened since the contributor stopped replying. #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments <hr>This is an automatic backport of pull request tendermint#5324 done by [Mergify](https://mergify.com). Co-authored-by: Alex | Interchain Labs <alex@cosmoslabs.io> Co-authored-by: arsushi <richie@asymmetric.re> Co-authored-by: Abdul Malek <me@almk.dev> Co-authored-by: Matt Acciai <matt@skip.money> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com> Co-authored-by: maradini77 <140460067+maradini77@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tried to cement the structure of the abci evidence for the cosmos-sdk
Used an enum for the evidence type of which there are two:
DUPLICATE_VOTE
LIGHT_CLIENT_ATTACK