Skip to content

config: rename prof_laddr to pprof_laddr and move it to rpc#5315

Merged
melekes merged 3 commits intomasterfrom
anton/unsafe-api-5303
Sep 1, 2020
Merged

config: rename prof_laddr to pprof_laddr and move it to rpc#5315
melekes merged 3 commits intomasterfrom
anton/unsafe-api-5303

Conversation

@melekes
Copy link
Copy Markdown
Contributor

@melekes melekes commented Sep 1, 2020

also, remove /unsafe_start_cpu_profiler, /unsafe_stop_cpu_profiler
and /unsafe_write_heap_profile in favor of pprof server functionality.

Closes #5303

also, remove `/unsafe_start_cpu_profiler`, `/unsafe_stop_cpu_profiler`
and `/unsafe_write_heap_profile` in favor of pprof server functionality.

Closes #5303
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 1, 2020

Codecov Report

Merging #5315 into master will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5315      +/-   ##
==========================================
- Coverage   62.46%   62.43%   -0.04%     
==========================================
  Files         258      258              
  Lines       27168    27143      -25     
==========================================
- Hits        16971    16946      -25     
+ Misses       8716     8715       -1     
- Partials     1481     1482       +1     
Impacted Files Coverage Δ
cmd/tendermint/commands/run_node.go 0.00% <0.00%> (ø)
config/config.go 77.83% <ø> (-0.06%) ⬇️
config/toml.go 65.95% <ø> (ø)
node/node.go 58.57% <0.00%> (-0.09%) ⬇️
rpc/core/dev.go 0.00% <ø> (ø)
rpc/core/routes.go 0.00% <ø> (ø)
crypto/sr25519/pubkey.go 37.93% <0.00%> (-6.90%) ⬇️
privval/signer_server.go 91.11% <0.00%> (-4.45%) ⬇️
blockchain/v0/pool.go 79.29% <0.00%> (-2.87%) ⬇️
p2p/switch.go 67.46% <0.00%> (-1.87%) ⬇️
... and 5 more

@melekes melekes marked this pull request as ready for review September 1, 2020 07:16
@melekes melekes self-assigned this Sep 1, 2020
Copy link
Copy Markdown
Contributor

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@melekes melekes merged commit 43c3e42 into master Sep 1, 2020
@melekes melekes deleted the anton/unsafe-api-5303 branch September 1, 2020 07:54
iKapitonau pushed a commit to scrtlabs/tendermint that referenced this pull request Oct 16, 2025
- clean up go.mod by organizing / grouping
- remove unused `third_party` dir
- properly set cometbft semver for upcoming v0.38.19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rpc: unsafe API duplicates pprof API

2 participants