Skip to content

proto: increase lint level to basic and fix lint warnings#5096

Merged
mergify[bot] merged 4 commits intomasterfrom
erik/proto-lint-basic
Jul 8, 2020
Merged

proto: increase lint level to basic and fix lint warnings#5096
mergify[bot] merged 4 commits intomasterfrom
erik/proto-lint-basic

Conversation

@erikgrinaker
Copy link
Copy Markdown
Contributor

@erikgrinaker erikgrinaker commented Jul 8, 2020

No description provided.

@erikgrinaker erikgrinaker added T:breaking Type: Breaking Change T:encoding Type: Amino, ProtoBuf S:automerge Automatically merge PR when requirements pass labels Jul 8, 2020
@erikgrinaker erikgrinaker requested a review from tac0turtle July 8, 2020 12:11
@erikgrinaker erikgrinaker self-assigned this Jul 8, 2020
@auto-comment
Copy link
Copy Markdown

auto-comment Bot commented Jul 8, 2020

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer
  • Applied Appropriate Labels

Thank you for your contribution to Tendermint! 🚀

tac0turtle
tac0turtle approved these changes Jul 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 8, 2020 •
edited
Loading

Codecov Report

Merging #5096 into master will increase coverage by 1.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5096      +/-   ##
==========================================
+ Coverage   61.53%   62.65%   +1.12%     
==========================================
  Files         197      256      +59     
  Lines       22917    27058    +4141     
==========================================
+ Hits        14101    16953    +2852     
- Misses       7567     8615    +1048     
- Partials     1249     1490     +241
Impacted Files Coverage Δ
privval/signer_listener_endpoint.go 82.60% <0.00%> (-4.35%) ⬇️
blockchain/v0/pool.go 79.29% <0.00%> (-2.23%) ⬇️
consensus/replay.go 72.57% <0.00%> (-0.85%) ⬇️
consensus/reactor.go 75.34% <0.00%> (-0.24%) ⬇️
consensus/state.go 71.96% <0.00%> (-0.10%) ⬇️
proxy/multi_app_conn.go 58.02% <0.00%> (ø)
libs/protoio/writer.go 38.23% <0.00%> (ø)
crypto/tmhash/hash.go 72.72% <0.00%> (ø)
libs/bits/bit_array.go 81.14% <0.00%> (ø)
libs/pubsub/subscription.go 91.30% <0.00%> (ø)
... and 58 more

@erikgrinaker erikgrinaker mentioned this pull request Jul 8, 2020
Merged
@mergify mergify Bot merged commit ab20f35 into master Jul 8, 2020
@mergify mergify Bot deleted the erik/proto-lint-basic branch July 8, 2020 13:27
mergify Bot pushed a commit that referenced this pull request Jul 8, 2020
@erikgrinaker
proto: improve enums (#5099)
59a17b2 
Fixes some minor issues with Protobuf enums, not likely to break anything.

Branched off of #5096, rebase to `master` before merging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tessr tessr Awaiting requested review from tessr

2 more reviewers

@melekes melekes melekes approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@erikgrinaker erikgrinaker

Labels

S:automerge Automatically merge PR when requirements pass T:breaking Type: Breaking Change T:encoding Type: Amino, ProtoBuf

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erikgrinaker @melekes @tac0turtle