Skip to content

crypto/merkle: remove simple prefix#4989

Merged
mergify[bot] merged 9 commits intomasterfrom
marko/2755_remove_simple
Jun 10, 2020
Merged

crypto/merkle: remove simple prefix#4989
mergify[bot] merged 9 commits intomasterfrom
marko/2755_remove_simple

Conversation

@tac0turtle
Copy link
Copy Markdown
Contributor

@tac0turtle tac0turtle commented Jun 9, 2020 •
edited
Loading

Description

This PR removes simple prefix from all types in the crypto/merkle directory.

The two proto types Proof & ProofOp have been moved to the proto/crypto/merkle directory.

proto messge Proof was renamed to ProofOps and SimpleProof message to Proof.

Closes: #2755

@auto-comment
Copy link
Copy Markdown

auto-comment Bot commented Jun 9, 2020

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer
  • Applied Appropriate Labels

Thank you for your contribution to Tendermint! 🚀

@tac0turtle tac0turtle self-assigned this Jun 9, 2020
@tac0turtle tac0turtle added C:crypto Component: Crypto T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Jun 9, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 9, 2020 •
edited
Loading

Codecov Report

Merging #4989 into master will decrease coverage by 0.49%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4989      +/-   ##
==========================================
- Coverage   63.70%   63.20%   -0.50%     
==========================================
  Files         181      185       +4     
  Lines       19447    19822     +375     
==========================================
+ Hits        12389    12529     +140     
- Misses       5997     6264     +267     
+ Partials     1061     1029      -32
Impacted Files Coverage Δ
light/rpc/client.go 0.00% <0.00%> (ø)
light/rpc/proof.go 0.00% <0.00%> (ø)
blockchain/v2/reactor.go 35.92% <0.00%> (-1.49%) ⬇️
consensus/reactor.go 72.11% <0.00%> (-0.56%) ⬇️
blockchain/v1/reactor.go 71.73% <0.00%> (-0.36%) ⬇️
p2p/conn/connection.go 79.69% <0.00%> (-0.07%) ⬇️
libs/protoio/io.go
state/execution.go
state/validation.go
state/state.go
... and 44 more

@tac0turtle tac0turtle marked this pull request as ready for review June 9, 2020 09:50
@tac0turtle tac0turtle requested review from melekes and tessr as code owners June 9, 2020 09:50
melekes
melekes approved these changes Jun 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread CHANGELOG_PENDING.md
- Apps

- [abci] [\#4704](https://github.com/tendermint/tendermint/pull/4704) Add ABCI methods `ListSnapshots`, `LoadSnapshotChunk`, `OfferSnapshot`, and `ApplySnapshotChunk` for state sync snapshots. `ABCIVersion` bumped to 0.17.0.
- [abci] \#4989 `Proof` within `ResponseQuery` has been renamed to `ProofOps`
Copy link
Copy Markdown
Contributor

@melekes melekes Jun 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what Ops stands for?

Copy link
Copy Markdown
Contributor Author

@tac0turtle tac0turtle Jun 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is short for ProofOperator the interface. I am torn with this in the abci. Someone will accidently screw this naming up

@tac0turtle tac0turtle added the S:automerge Automatically merge PR when requirements pass label Jun 10, 2020
@mergify mergify Bot merged commit 46f6d17 into master Jun 10, 2020
@mergify mergify Bot deleted the marko/2755_remove_simple branch June 10, 2020 14:57
@tcrognon tcrognon mentioned this pull request Jul 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tessr tessr Awaiting requested review from tessr

1 more reviewer

@melekes melekes melekes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tac0turtle tac0turtle

Labels

C:crypto Component: Crypto S:automerge Automatically merge PR when requirements pass T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

crypto/merkle: Remove "Simple" Prefix

2 participants

@tac0turtle @melekes