Skip to content

light: rename lite2 to light & remove lite#4946

Merged
mergify[bot] merged 5 commits intomasterfrom
marko/4944_rename_lite
Jun 3, 2020
Merged

light: rename lite2 to light & remove lite#4946
mergify[bot] merged 5 commits intomasterfrom
marko/4944_rename_lite

Conversation

@tac0turtle
Copy link
Copy Markdown
Contributor

@tac0turtle tac0turtle commented Jun 3, 2020 •
edited
Loading

This PR removes lite & renames lite2 to light throughout the repo

Signed-off-by: Marko Baricevic marbar3778@yahoo.com

Closes: #4944

@tac0turtle
light: rename lite2 to light
027b758 
This PR removes lite & renames lite2 to light throughtout the repo

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
@tac0turtle tac0turtle requested review from melekes and tessr as code owners June 3, 2020 09:40
@auto-comment
Copy link
Copy Markdown

auto-comment Bot commented Jun 3, 2020

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer
  • Applied Appropriate Labels

Thank you for your contribution to Tendermint! 🚀

@tac0turtle tac0turtle marked this pull request as draft June 3, 2020 09:40
@tac0turtle tac0turtle self-assigned this Jun 3, 2020
@tac0turtle tac0turtle added the C:light Component: Light label Jun 3, 2020
@tac0turtle tac0turtle marked this pull request as ready for review June 3, 2020 09:45
@tac0turtle tac0turtle added the S:automerge Automatically merge PR when requirements pass label Jun 3, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2020

Codecov Report

Merging #4946 into master will increase coverage by 0.68%.
The diff coverage is 25.71%.

@@            Coverage Diff             @@
##           master    #4946      +/-   ##
==========================================
+ Coverage   62.73%   63.41%   +0.68%     
==========================================
  Files         197      187      -10     
  Lines       20090    19469     -621     
==========================================
- Hits        12604    12347     -257     
+ Misses       6458     6130     -328     
+ Partials     1028      992      -36
Impacted Files Coverage Δ
light/client.go 73.49% <ø> (ø)
light/errors.go 71.42% <ø> (ø)
light/rpc/client.go 0.00% <0.00%> (ø)
light/rpc/proof.go 0.00% <ø> (ø)
light/setup.go 0.00% <ø> (ø)
light/store/db/db.go 76.27% <ø> (ø)
light/trust_options.go 18.18% <ø> (ø)
light/verifier.go 81.91% <ø> (ø)
node/node.go 58.90% <0.00%> (ø)
statesync/stateprovider.go 0.00% <0.00%> (ø)
... and 12 more

cmwaters
cmwaters approved these changes Jun 3, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍾 👍 - Side question: why is light/rpc/query_test.go all commented out - is there plans for this file @melekes ?

@mergify mergify Bot merged commit c2578e2 into master Jun 3, 2020
@mergify mergify Bot deleted the marko/4944_rename_lite branch June 3, 2020 10:13
@melekes
Copy link
Copy Markdown
Contributor

melekes commented Jul 10, 2020 •
edited
Loading

@cmwaters: #5106

iKapitonau pushed a commit to scrtlabs/tendermint that referenced this pull request Oct 16, 2025
@mergify @melekes
ci: remove govulncheck (backport tendermint#4946) (tendermint#4961)
8c1d050 
Closes tendermint#4945
<hr>This is an automatic backport of pull request tendermint#4946 done by
[Mergify](https://mergify.com).

---------

Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Co-authored-by: Zachary Becker <zachary@interchainlabs.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@melekes melekes Awaiting requested review from melekes

@tessr tessr Awaiting requested review from tessr

1 more reviewer

@cmwaters cmwaters cmwaters approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tac0turtle tac0turtle

Labels

C:light Component: Light S:automerge Automatically merge PR when requirements pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

light: remove lite & rename lite2 -> light

3 participants

@tac0turtle @melekes @cmwaters