[Scala] Added newline bailout for annotation type tails#2347
Merged
wbond merged 2 commits intosublimehq:masterfrom Aug 18, 2020
Merged
[Scala] Added newline bailout for annotation type tails#2347wbond merged 2 commits intosublimehq:masterfrom
wbond merged 2 commits intosublimehq:masterfrom
Conversation
wbond
reviewed
Jul 20, 2020
| type Apply = F @uncheckedVariance | ||
| type A | ||
| // ^^^^ storage.type.scala | ||
| // ^ entity.name.type.scala |
Member
There was a problem hiding this comment.
Should there be a } on the last line?
Contributor
Author
There was a problem hiding this comment.
Very likely yes! It's been a while since I looked at this PR. I'll try to update it.
charlievieth
pushed a commit
to charlievieth/Packages
that referenced
this pull request
Aug 25, 2020
mitranim
pushed a commit
to mitranim/Packages
that referenced
this pull request
Mar 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Annotations at end-of-line within a single type expression would result in the subsequent line(s) being incorrectly scoped due to the way the lookahead was being processed. Catching this case explicitly allows us to (correctly) pop out of the context.