Fix length-zero-no-unit autofix for .0 values#6098
Merged
ybiquitous merged 1 commit intostylelint:mainfrom May 19, 2022
Merged
Conversation
ybiquitous
approved these changes
May 19, 2022
Member
ybiquitous
left a comment
There was a problem hiding this comment.
@playhardgopro Thank you for your first contribution! The fix looks good to me. 👍🏼
The case of .0 is not related to length-zero-no-unit, so there are no problems.
length-zero-no-unit bug with '.0rem' -> ''length-zero-no-unit autofix with .0rem
length-zero-no-unit autofix with .0remlength-zero-no-unit autofix with .0{unit}
length-zero-no-unit autofix with .0{unit} length-zero-no-unit autofix for .0 values
Member
|
Changelog entry added:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6074
I tested these changes in the reproduction repository and
So should we fix it for the second case? It doesn't seem to be the problem with this rule. @ybiquitous correct me if I'm wrong.