Skip to content

Fix no-invalid-position-at-import-rule false positives for @layer#6094

Merged
ybiquitous merged 2 commits intostylelint:mainfrom
immitsu:add-layer-to-at-import-rule
May 16, 2022
Merged

Fix no-invalid-position-at-import-rule false positives for @layer#6094
ybiquitous merged 2 commits intostylelint:mainfrom
immitsu:add-layer-to-at-import-rule

Conversation

@immitsu
Copy link
Copy Markdown
Contributor

@immitsu immitsu commented May 14, 2022

Which issue, if any, is this issue related to?

Resolve #6085

Is there anything in the PR that needs further explanation?

No.

Copy link
Copy Markdown
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@immitsu Thanks for creating the pull request. Almost LGTM 👍🏼

Can you please update the doc also "ignoring @charset"? ⬇️

Any `@import` rules must precede all other valid at-rules and style rules in a stylesheet (ignoring `@charset`), or else the `@import` rule is invalid.

@ybiquitous ybiquitous changed the title extend if-block Fix no-invalid-position-at-import-rule false positives for @layer May 15, 2022
@immitsu
Copy link
Copy Markdown
Contributor Author

immitsu commented May 15, 2022

@ybiquitous Done!

Copy link
Copy Markdown
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ybiquitous ybiquitous merged commit 1a1bbde into stylelint:main May 16, 2022
@ybiquitous
Copy link
Copy Markdown
Member

Changelog entry added:

Fixed: no-invalid-position-at-import-rule false positives for @layer (#6094).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

[no-invalid-position-at-import-rule] Should allow @layer to come before @import

2 participants