Skip to content

Fix false positives/negatives in selector-pseudo-class-no-unknown#5956

Merged
jeddy3 merged 2 commits intostylelint:mainfrom
Mouvedia:mouvedia-5173
Mar 9, 2022
Merged

Fix false positives/negatives in selector-pseudo-class-no-unknown#5956
jeddy3 merged 2 commits intostylelint:mainfrom
Mouvedia:mouvedia-5173

Conversation

@Mouvedia
Copy link
Copy Markdown
Member

@Mouvedia Mouvedia commented Mar 8, 2022

Which issue, if any, is this issue related to?

Closes #5173

Is there anything in the PR that needs further explanation?

check the commit message for details
prompted by #5205 (comment)

 - `user-valid`
 - `-moz-placeholder`
 - `-moz-ui-invalid`
 - `-moz-ui-valid`
 - `-ms-input-placeholder`

add missing pseudo elements:
 - `-moz-focus-outer`
 - `-moz-placeholder`
 - `-webkit-input-placeholder`

fixes stylelint#5173

https://developer.mozilla.org/en-US/docs/web/css/:user-valid
https://bugzilla.mozilla.org/show_bug.cgi?id=457801
https://bugzilla.mozilla.org/show_bug.cgi?id=737786
Comment thread lib/reference/keywordSets.js Outdated
Copy link
Copy Markdown
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Let's remove user-error too.

Comment thread lib/reference/keywordSets.js Outdated
@jeddy3 jeddy3 changed the title Remove :contains() (#5173), Add missing pseudo elements/classes (non exhaustive) Fix false positives/negatives in selector-pseudo-class-no-unknown Mar 8, 2022
@Mouvedia
Copy link
Copy Markdown
Member Author

Mouvedia commented Mar 8, 2022

Let's remove user-error too.

done

Copy link
Copy Markdown
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM.

Copy link
Copy Markdown
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍🏼

Comment thread lib/reference/keywordSets.js
@jeddy3 jeddy3 merged commit 60dd0c3 into stylelint:main Mar 9, 2022
@jeddy3
Copy link
Copy Markdown
Member

jeddy3 commented Mar 9, 2022

Changelog entry added:

  • Fixed: selector-pseudo-class-no-unknown false positives and negatives (#5956).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Fix false negatives for :contains in selector-pseudo-class-no-unknown

3 participants