Skip to content

Ignore PHP version for formatting#1426

Merged
pakrym-stripe merged 2 commits intomasterfrom
pakrym/Ignore_PHP_version_for_formatting
Jan 19, 2023
Merged

Ignore PHP version for formatting#1426
pakrym-stripe merged 2 commits intomasterfrom
pakrym/Ignore_PHP_version_for_formatting

Conversation

@pakrym-stripe
Copy link
Copy Markdown
Contributor

@pakrym-stripe pakrym-stripe commented Jan 19, 2023

Some of machines we run publishing from have PHP 8.2 that's not supported by php-fixer yet. Suppressing the error doesn't produce any unexpected results and lets the codegen succeed.

Copy link
Copy Markdown
Contributor

@anniel-stripe anniel-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@pakrym-stripe pakrym-stripe merged commit ea209fa into master Jan 19, 2023
@remi-stripe remi-stripe deleted the pakrym/Ignore_PHP_version_for_formatting branch September 28, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants