Skip to content

Multiple API changes#1016

Merged
ctrudeau-stripe merged 2 commits intomasterfrom
ctrudeau/codegen-dcd3c3f
Sep 24, 2020
Merged

Multiple API changes#1016
ctrudeau-stripe merged 2 commits intomasterfrom
ctrudeau/codegen-dcd3c3f

Conversation

@ctrudeau-stripe
Copy link
Copy Markdown
Contributor

@ctrudeau-stripe ctrudeau-stripe commented Sep 24, 2020

Multiple API changes

  • Add support for OXXO on PaymentMethod and PaymentIntent
  • Add support for contribution on BalanceTransaction

Codegen for openapi dcd3c3f + manual revert of the StripeResource type changes

r? @remi-stripe
cc @stripe/api-libraries

setAppInfo(info: Stripe.AppInfo): void;

StripeResource: Stripe.StripeResource;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change, something was missed and that can not be merged

@ctrudeau-stripe
Copy link
Copy Markdown
Contributor Author

ptal @remi-stripe

Removed the breaking change.

Copy link
Copy Markdown
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to use the bullet points from the description I updated in your PR

@ctrudeau-stripe ctrudeau-stripe merged commit c378661 into master Sep 24, 2020
@ctrudeau-stripe ctrudeau-stripe deleted the ctrudeau/codegen-dcd3c3f branch September 24, 2020 23:33
gurus00 pushed a commit to gurus00/stripe-node that referenced this pull request Feb 11, 2025
gurus00 pushed a commit to gurus00/stripe-node that referenced this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants