Skip to content

extract operator: add support for Postgres keywords #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alamb merged 1 commit into from
Mar 7, 2022
Merged

extract operator: add support for Postgres keywords #427

alamb merged 1 commit into from
Mar 7, 2022

Conversation

@mobuchowski
Copy link
Contributor

@mobuchowski mobuchowski commented Feb 28, 2022

Postgres supports more keywords in EXTRACT operator than currently supported.
This adds support for them.

https://www.postgresql.org/docs/current/functions-datetime.html#FUNCTIONS-DATETIME-EXTRACT

Signed-off-by: Maciej Obuchowski obuchowski.maciej@gmail.com

@mobuchowski
extract operator: add support for Postgres keywords
afae89c 
Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
@mobuchowski
Copy link
Contributor Author

mobuchowski commented Mar 7, 2022

@alamb @houqp could you take a look?

I know you're not maintaining this project very actively, but this seem to be a benign change to me.

Dandandan
Dandandan approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@Dandandan Dandandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@alamb
Copy link
Contributor

alamb commented Mar 7, 2022

Thanks @mobuchowski and @Dandandan -- I am hoping to find time later this week to make a sql parser release and will include this one in it

@alamb alamb merged commit 3af3ca0 into apache:main Mar 7, 2022
@coveralls
Copy link

coveralls commented Mar 7, 2022

Pull Request Test Coverage Report for Build 1912084938

  • 30 of 45 (66.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 90.443%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser.rs 15 30 50.0%
Totals Coverage Status
Change from base Build 1912079135: -0.1%
Covered Lines: 7183
Relevant Lines: 7942
💛 - Coveralls

@alamb alamb mentioned this pull request Mar 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dandandan Dandandan Dandandan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mobuchowski @alamb @coveralls @Dandandan