Add authorizeHttpRequests to Kotlin DSL#10895
Merged
Merged
Conversation
jzheaux
requested changes
Feb 24, 2022
jzheaux
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, @ysavchen! I've left some feedback inline.
I'd also like to have @eleftherias take a look since she is quite a bit more familiar with the Kotlin DSL than I am.
eleftherias
suggested changes
Feb 28, 2022
eleftherias
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR @ysavchen!
I would like to have a test for what happens when we use both authorizeRequests and authorizeHttpRequests in the Kotlin DSL.
I've also left one commend inline.
Collaborator
|
Hi, @ysavchen. Are you able to make the requested changes? |
Contributor
Author
|
Sorry for delay @jzheaux. I needed some time to analyze the options. |
jzheaux
approved these changes
Mar 17, 2022
eleftherias
approved these changes
Mar 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-10481
Comparing to
AuthorizeRequestsDslTests, the newly addedAuthorizeHttpRequestsDslTestsdoes not include the following test:As far as I understand
authorizeHttpRequestsAPI does not provide SpEL support and this test seems obsolete.But due to default value for access parameter, there is a mismatch between
authorizeRequestsandauthorizeHttpRequetsAPI: