Skip to content

Correctly identify MaxUploadSizeExceededException through keywords in message from Jetty 9.4.x#28759

Closed
kacperkrzyzak wants to merge 1 commit into
spring-projects:mainfrom
kacperkrzyzak:MaxUploadSizeExceededException_Jetty_9.4.x_support
Closed

Correctly identify MaxUploadSizeExceededException through keywords in message from Jetty 9.4.x#28759
kacperkrzyzak wants to merge 1 commit into
spring-projects:mainfrom
kacperkrzyzak:MaxUploadSizeExceededException_Jetty_9.4.x_support

Conversation

@kacperkrzyzak

Copy link
Copy Markdown
Contributor

MaxUploadSizeExceededException is recognized based on the exception message containing the words "size" and "exceed". Jetty server throws a message "Request exceeds maxRequestSize...". Shouldn't such message also be treated as a MaxUploadSizeExceededException?

The proposed change addresses the issue regarding handling errors for too large file uploads when using the Jetty 9.4.x server. Now it is possible that MultipartException is thrown instead of MaxUploadSizeExceededException when the file exceeds the size limit.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 5, 2022
@jhoeller jhoeller added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 13, 2022
@jhoeller jhoeller added this to the 5.3.22 milestone Jul 13, 2022
@sbrannen sbrannen self-assigned this Jul 13, 2022
@sbrannen sbrannen closed this in 10838a6 Jul 13, 2022
@sbrannen

Copy link
Copy Markdown
Member

This has been merged into 5.3.x and main.

Thanks, and congratulations on submitting your first PR to the Spring Framework! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants