Skip to content

Ensure channelExecutors and taskScheduler in STOMP WebSocket config are qualified#28736

Closed
CodeInDreams wants to merge 1 commit into
spring-projects:mainfrom
CodeInDreams:fix-executors-autowiring
Closed

Ensure channelExecutors and taskScheduler in STOMP WebSocket config are qualified#28736
CodeInDreams wants to merge 1 commit into
spring-projects:mainfrom
CodeInDreams:fix-executors-autowiring

Conversation

@CodeInDreams

@CodeInDreams CodeInDreams commented Jun 30, 2022 •
edited by rstoyanchev
Loading

Copy link
Copy Markdown
Contributor

There are several beans require TaskExecutor or TaskScheduler without @Qualifier, which means inject wrong executors if we declare some executor bean @Primary.

As previously discussed at #28719, I use @Qualifier instead to avoid cglib proxies.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 30, 2022
@sbrannen sbrannen added in: web Issues in web modules (web, webmvc, webflux, websocket) in: messaging Issues in messaging modules (jms, messaging) labels Jun 30, 2022
@sbrannen sbrannen modified the milestone: Triage Queue Jun 30, 2022
@sbrannen

sbrannen commented Jun 30, 2022

Copy link
Copy Markdown
Member

Related Issues:

@rstoyanchev

rstoyanchev commented Jul 4, 2022

Copy link
Copy Markdown
Contributor

This looks okay to me. What do you think @sdeleuze, @jhoeller?

@rstoyanchev rstoyanchev self-assigned this Jul 4, 2022
@rstoyanchev rstoyanchev modified the milestones: Triage Queue, 5.3.22 Jul 4, 2022
@rstoyanchev rstoyanchev added type: regression A bug that is also a regression and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 4, 2022
@rstoyanchev rstoyanchev changed the title Fix issue autowiring channelExecutors and taskScheduler in spring messaging & websocket Ensure channelExecutors and taskScheduler in STOMP WebSocket config are qualified Jul 4, 2022
@rstoyanchev

rstoyanchev commented Jul 4, 2022

Copy link
Copy Markdown
Contributor

We'll fix this in 5.3.x. Note that a similar change was applied to the web config as well #23887.

rstoyanchev pushed a commit that referenced this pull request Jul 4, 2022
@CodeInDreams @rstoyanchev
Qualify channelExecutor and taskScheduler in WebSocket config
461ba53 
See gh-28736
rstoyanchev added a commit that referenced this pull request Jul 4, 2022
@rstoyanchev
Add missing check to avoid re-initialization
007bded 
Noticed during review of #28736 that a check protecting against
re-initialization was accidentally removed in commit
3d6e38b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@rstoyanchev rstoyanchev

Labels

in: messaging Issues in messaging modules (jms, messaging) in: web Issues in web modules (web, webmvc, webflux, websocket) type: regression A bug that is also a regression

Projects

None yet

Milestone

5.3.22

Development

Successfully merging this pull request may close these issues.

4 participants

@CodeInDreams @sbrannen @rstoyanchev @spring-projects-issues