Add application/vnd.google.protobuf to ProtobufCodecSupport#26487
Merged
rstoyanchev merged 1 commit intospring-projects:masterfrom Feb 2, 2021
making:patch-1
Merged
Add application/vnd.google.protobuf to ProtobufCodecSupport#26487rstoyanchev merged 1 commit intospring-projects:masterfrom making:patch-1
rstoyanchev merged 1 commit intospring-projects:masterfrom
making:patch-1
Conversation
Member
|
@making |
Member
Author
|
I think it's safe to keep it for the backwards compatibility. |
Member
|
Member
|
Ha, never mind I misread the diff. Thanks! |
Contributor
|
I think this safe to do. It would expand the capability on the decoding side, but on the encoding side we still default to the first one on the list. |
This was referenced Mar 7, 2021
This was referenced Mar 13, 2021
Merged
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While RSocket spec supports
application/vnd.google.protobufas a Well-known MIME Type, Protobuf Codec doesn't.As a result, Spring RSocket app that has
ProtobufDecoderconfigured can not receive a payload withapplication/vnd.google.protobufdata mime type.https://github.com/rsocket/rsocket/blob/master/Extensions/WellKnownMimeTypes.md