Skip to content

Fix wrong reference in UrlPathHelper.removeSemicolonContentInternal()#26050

Merged
jhoeller merged 1 commit intospring-projects:masterfrom
izeye:url-path-helper
Nov 9, 2020
Merged

Fix wrong reference in UrlPathHelper.removeSemicolonContentInternal()#26050
jhoeller merged 1 commit intospring-projects:masterfrom
izeye:url-path-helper

Conversation

@izeye
Copy link
Contributor

@izeye izeye commented Nov 9, 2020

This PR fixes a wrong reference in UrlPathHelper.removeSemicolonContentInternal().

This PR also changes to short-circuit when slashIndex is -1.

This commit also changes to short-circuit when `slashIndex` is -1.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 9, 2020
@jhoeller jhoeller self-assigned this Nov 9, 2020
@jhoeller jhoeller added in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 9, 2020
@jhoeller jhoeller added this to the 5.3.1 milestone Nov 9, 2020
@jhoeller jhoeller merged commit 0c34776 into spring-projects:master Nov 9, 2020
@jhoeller
Copy link
Contributor

jhoeller commented Nov 9, 2020

Good catch, that was an accidental leftover from #26012. Thanks for the timely PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants