Add FullyQualifiedAnnotationBeanNameGenerator.INSTANCE#26025
Merged
jhoeller merged 1 commit intospring-projects:masterfrom Nov 4, 2020
Merged
Add FullyQualifiedAnnotationBeanNameGenerator.INSTANCE#26025jhoeller merged 1 commit intospring-projects:masterfrom
jhoeller merged 1 commit intospring-projects:masterfrom
Conversation
Adds a static INSTANCE to FullyQualifiedAnnotationBeanNameGenerator, just like its parent class, AnnotationBeanNameGenerator, does. The class doesn't have any state and overriding/hiding the INSTANCE of the superclass, this prevents unintended use of a regular AnnotationBeanNameGenerator through FullyQualifiedAnnotationBeanNameGenerator.INSTANCE.
jhoeller
added a commit
that referenced
this pull request
Nov 4, 2020
Contributor
Author
|
Thanks for merging! :) |
jhoeller
added a commit
that referenced
this pull request
Nov 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spring 5.2.3 (b4c91e7) introduces the
FullyQualifiedAnnotationBeanNameGenerator, but does not override/hide the staticINSTANCEfield from its parent, which seems confusing to me. Someone might accessFullyQualifiedAnnotationBeanNameGenerator.INSTANCEand get aAnnotationBeanNameGeneratorinstead. Just like I did. 😅This PR aims to solve that by adding a static
INSTANCEfield toFullyQualifiedAnnotationBeanNameGenerator, like its parent does too.