Skip to content

Warning that DefaultClientResources was not shutdown properly when using Lettuce with Actuator#28767

Closed
quaff wants to merge 1 commit into
spring-projects:mainfrom
quaff:patch-11
Closed

Warning that DefaultClientResources was not shutdown properly when using Lettuce with Actuator#28767
quaff wants to merge 1 commit into
spring-projects:mainfrom
quaff:patch-11

Conversation

@quaff

@quaff quaff commented Nov 22, 2021

Copy link
Copy Markdown
Contributor

It is not the responsibility of ClientResourcesBuilderCustomizer to build ClientResources instance.

Fix:

i.l.c.r.DefaultClientResources WARN io.lettuce.core.resource.DefaultClientResources was not shut down properly, shutdown() was not called before it's garbage-collected. Call shutdown() or shutdown(long,long,TimeUnit)

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 22, 2021
…ance

Fix:
i.l.c.r.DefaultClientResources WARN io.lettuce.core.resource.DefaultClientResources was not shut down properly, shutdown() was not called before it's garbage-collected. Call shutdown() or shutdown(long,long,TimeUnit)
@wilkinsona wilkinsona added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 22, 2021
@wilkinsona wilkinsona added this to the 2.6.x milestone Nov 22, 2021
@snicoll snicoll modified the milestones: 2.6.x, 2.6.1 Nov 22, 2021
@snicoll snicoll self-assigned this Nov 22, 2021
@snicoll snicoll closed this in cdc2851 Nov 22, 2021
@snicoll

snicoll commented Nov 22, 2021

Copy link
Copy Markdown
Member

@quaff good catch, thanks again.

@wilkinsona wilkinsona changed the title LettuceMetricsAutoConfiguration should not build ClientResources instance Warning that DefaultClientResources was not shutdown properly when using Lettuce with Actuator Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants