Skip to content

Fix renaming a dir with sub-directories#239

Merged
bep merged 1 commit intospf13:masterfrom
nono:fix-mem-rename
Feb 23, 2023
Merged

Fix renaming a dir with sub-directories#239
bep merged 1 commit intospf13:masterfrom
nono:fix-mem-rename

Conversation

@nono
Copy link
Copy Markdown
Contributor

@nono nono commented Apr 11, 2020

I think it should fix issue #141

Comment thread memmap_test.go
Comment thread memmap_test.go
Comment thread memmap.go Outdated
@nono
Copy link
Copy Markdown
Contributor Author

nono commented Feb 23, 2023

@bep hi, this is an old pull request but I think it would still be a good fix for afero. I have rebased it and listened to the comments made by @0xmichalis. If you have time to look at it, it would be appreciated.

@bep bep merged commit 3b1116b into spf13:master Feb 23, 2023
@nono
Copy link
Copy Markdown
Contributor Author

nono commented Feb 23, 2023

Thanks ❤️

@hanagantig
Copy link
Copy Markdown
Contributor

hanagantig commented May 1, 2023

It doesn't fix the issue #141
I have described the problem here #141 (comment)

You can check my one year old PR which fix it #364

messikiller pushed a commit to messikiller/afero that referenced this pull request Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants