Improve clarity of 'content' error message for files_upload_v2#1278
Merged
seratch merged 1 commit intoslackapi:mainfrom Oct 24, 2022
eddyg:main
Merged
Improve clarity of 'content' error message for files_upload_v2#1278seratch merged 1 commit intoslackapi:mainfrom eddyg:main
seratch merged 1 commit intoslackapi:mainfrom
eddyg:main
Conversation
seratch
approved these changes
Oct 17, 2022
Contributor
seratch
left a comment
There was a problem hiding this comment.
Thank you! Looks good to me.
Codecov Report
@@ Coverage Diff @@
## main #1278 +/- ##
==========================================
+ Coverage 85.63% 85.70% +0.06%
==========================================
Files 84 84
Lines 7826 7826
==========================================
+ Hits 6702 6707 +5
+ Misses 1124 1119 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Very simple PR to improve the clarity of the error message raised when 'content' is specified and it's not the correct type. (Feel free to edit as you see fit, or simply disregard if it's too minor.)
It is worth noting that the
elsecase of this comparison (where neithercontentnorfile_uploadsis specified) is already handled here (for the async client) and here (regular).Category (place an
xin each of the[ ])/docs-src(Documents, have you run./scripts/docs.sh?)/docs-src-v2(Documents, have you run./scripts/docs-v2.sh?)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements (place an
xin each[ ])python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.