add selected_time (timepicker) to ViewStateValue class#1266
Merged
seratch merged 1 commit intoslackapi:mainfrom Sep 19, 2022
Merged
add selected_time (timepicker) to ViewStateValue class#1266seratch merged 1 commit intoslackapi:mainfrom
seratch merged 1 commit intoslackapi:mainfrom
Conversation
|
|
Contributor
|
@rei-0 Thanks for sending this fix! Would you mind signing the CLA? Without it, we are unable to merge any external contributions. It’d be appreciated if you could understand this. |
Codecov Report
@@ Coverage Diff @@
## main #1266 +/- ##
=======================================
Coverage 86.65% 86.66%
=======================================
Files 111 111
Lines 11026 11027 +1
=======================================
+ Hits 9555 9556 +1
Misses 1471 1471
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
|
@seratch Signed! |
seratch
approved these changes
Sep 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New
TimePickerelement is not supported in theViewStateValueclass. See issue #1265Category (place an
xin each of the[ ])/docs-src(Documents, have you run./scripts/docs.sh?)/docs-src-v2(Documents, have you run./scripts/docs-v2.sh?)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements (place an
xin each[ ])python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.