fix retry_handlers type in AsyncBaseClient#1264
Merged
seratch merged 1 commit intoslackapi:mainfrom Sep 15, 2022
Merged
Conversation
|
|
Contributor
|
Hi @ronyb29, thanks a lot for taking the time to send this PR! The changes look great to me but it seems that this is your first contribution to this project. Would you mind signing our CLA (see the above bot message for details)? Without it, we are unable to merge any contributions. It'd be appreciated if you could understand this. |
Contributor
Author
|
hey @seratch, |
Codecov Report
@@ Coverage Diff @@
## main #1264 +/- ##
==========================================
+ Coverage 86.57% 86.64% +0.07%
==========================================
Files 111 111
Lines 11026 11026
==========================================
+ Hits 9546 9554 +8
+ Misses 1480 1472 -8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixing the types for retry_handlers in the async client, according to docs and the code itself it should have been
AsyncRetryHandlerfrom the beggningCategory (place an
xin each of the[ ])/docs-src(Documents, have you run./scripts/docs.sh?)/docs-src-v2(Documents, have you run./scripts/docs-v2.sh?)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements (place an
xin each[ ])python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.