Add in timezone property for timepicker element#1251
Merged
seratch merged 4 commits intoslackapi:mainfrom Aug 3, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1251 +/- ##
=======================================
Coverage 86.64% 86.64%
=======================================
Files 111 111
Lines 11025 11026 +1
=======================================
+ Hits 9553 9554 +1
Misses 1472 1472
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
fe8ce75 to
fedb48d
Compare
seratch
suggested changes
Aug 2, 2022
Contributor
seratch
left a comment
There was a problem hiding this comment.
Thanks, LGTM but can you revert the document changes? We generate them when releasing a new version.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding in a new
timezonestring property to the TimePicker block element. See #1249 for more info.Along with adding in the new property in
slack_sdk/models/blocks/block_elements.py, also updated and previewed the docs and added a unit test corresponding to the addition of this new property.Category (place an
xin each of the[ ])/docs-src(Documents, have you run./scripts/docs.sh?)/docs-src-v2(Documents, have you run./scripts/docs-v2.sh?)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements (place an
xin each[ ])python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.