Skip to content

Update aiohttp documentation sample#1245

Merged
seratch merged 2 commits intoslackapi:mainfrom
srajiang:documentation
Jul 22, 2022
Merged

Update aiohttp documentation sample#1245
seratch merged 2 commits intoslackapi:mainfrom
srajiang:documentation

Conversation

@srajiang
Copy link
Copy Markdown
Contributor

@srajiang srajiang commented Jul 22, 2022

Summary

Fixes #1244. Slightly modifies example code so that it runs correctly as described

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • [] I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

seratch
seratch approved these changes Jul 22, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@seratch seratch added docs M-T: Documentation work only Version: 3x socket-mode labels Jul 22, 2022
@seratch seratch added this to the 3.18.1 milestone Jul 22, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 22, 2022

Codecov Report

Merging #1245 (a4719ec) into main (a1ad5a4) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1245      +/-   ##
==========================================
- Coverage   86.61%   86.56%   -0.05%     
==========================================
  Files         111      111              
  Lines       11026    11026              
==========================================
- Hits         9550     9545       -5     
- Misses       1476     1481       +5
Impacted Files Coverage Δ
slack_sdk/socket_mode/builtin/internals.py 71.92% <0.00%> (-2.20%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@srajiang srajiang mentioned this pull request Jul 22, 2022
Closed
@seratch seratch merged commit e24c270 into slackapi:main Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@seratch seratch seratch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@srajiang srajiang

Labels

docs M-T: Documentation work only socket-mode Version: 3x

Projects

None yet

Milestone

3.18.1

Development

Successfully merging this pull request may close these issues.

Socket Mode Client example using aiohttp doesn't work

2 participants

@srajiang @seratch